piercemar commented on PR #1370: URL: https://github.com/apache/maven-scm/pull/1370#issuecomment-5546755949
I personally did not notice any significant slowdown on windows, for simple `check-local-modification`, that is. Do you have other use case in mind? Le ven. 4 sept. 2026, 22:02, Michael Osipov ***@***.***> a écrit : > ***@***.**** commented on this pull request. > ------------------------------ > > In > maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/status/JGitStatusCommand.java > <https://github.com/apache/maven-scm/pull/1370#discussion_r3937524601>: > > > @@ -51,7 +56,19 @@ protected StatusScmResult executeStatusCommand(ScmProviderRepository repo, ScmFi > git = JGitUtils.openRepo(fileSet.getBasedir()); > Status status = git.status().call(); > List<ScmFile> changedFiles = getFileStati(status); > - > + if (isFileSetFiltered(fileSet)) { > + // account for difference in repo and fileSet base path > + File gitRoot = git.getRepository().getWorkTree().getCanonicalFile(); > + File fileSetBase = fileSet.getBasedir().getCanonicalFile(); > > This can be very espensive on Windows... > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-scm/pull/1370?email_source=notifications&email_token=AFLTCQTUAZUMVEZ2HBHBBVD5NMNXFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJRG4ZTENJQG4Z2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-5117325073>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFLTCQRM4C3FVZAIM62HTYL5NMNXFAVCNFSNUABCKJSXA33TNF2G64TZHMZDANRTGIYDWSLTON2WKOZUGIZDIMBWHA4DOMFBOYBA> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AFLTCQRWQ64TMVRRYZPBKPT5NMNXFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJRG4ZTENJQG4Z2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AFLTCQTE47PQTQLU7YLU5LT5NMNXFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJRG4ZTENJQG4Z2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
