gnodet commented on code in PR #13080:
URL: https://github.com/apache/maven/pull/13080#discussion_r3975861052
##########
impl/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java:
##########
@@ -35,29 +36,29 @@
*/
public abstract class AbstractLifecycleMappingProvider implements
Provider<LifecycleMapping> {
// START SNIPPET: versions
- protected static final String RESOURCES_PLUGIN_VERSION = "3.3.1";
+ protected static final String RESOURCES_PLUGIN_VERSION =
PluginVersions.RESOURCES;
Review Comment:
Agreed — since these fields are `protected` and could be referenced by
extensions subclassing `AbstractLifecycleMappingProvider`, I'll deprecate them
for 4.1.0 with `@Deprecated(since = "4.1.0", forRemoval = true)` rather than
removing outright. They already delegate to `PluginVersions.*` constants, so
the deprecation is purely a signal to migrate.
_This comment was generated by an AI agent, Hermès, on behalf of @gnodet._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
