goutamadwant commented on PR #13081: URL: https://github.com/apache/maven/pull/13081#issuecomment-5614202893
> Maven 4 already has a relocation SPI: `MavenArtifactRelocationSource` (`distributionManagement`, `userProperties`), walked with cycle detection in `DefaultArtifactDescriptorReader.loadPom`. This adds a second walker for `distributionManagement` only, and imports resolve via `DefaultModelResolver`, which never consults those sources, so `maven.relocations.entries` cannot reach an imported BOM. Intended? > > Also a relocation-only loop reports "dependencies of type=pom and with scope=import form a cycle" though one import is declared; `loadPom` words it "Artifact relocations form a cycle". Yes, this fix is limited to distributionManagement relocations in imported BOMs. Imports use ModelResolver rather than the artifact-descriptor relocation SPI; extending maven.relocations.entries to BOM imports would be a separate change. Changed the diagnostic to “The import POMs form a cycle”, covering ordinary imports, relocations, and mixed cycles. Both model builders now assert the message and cycle path. @gnodet, could you approve the new CI run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
