slachiewicz commented on PR #393: URL: https://github.com/apache/maven-shared-utils/pull/393#issuecomment-5615047417
Pushed two commits to this branch: merged current `master` (which now carries the [#422](https://github.com/apache/maven-shared-utils/pull/422) fix, so the branch builds green again), and addressed the review point on the new test. The test now restores `org.xml.sax.driver` in a `finally` block. `build()` must not touch that property, which is exactly what the test asserts, but if that ever regresses the old form would leave the mutated value behind and take unrelated tests down with it. This keeps the blast radius to this test, matching how `OsTest` handles system properties here. No change to `Xpp3DomBuilder` itself. Verified: `mvn -B verify` on JDK 17 -> Tests run: 788, Failures: 0, Errors: 0. Spotless clean. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
