slachiewicz opened a new pull request, #426: URL: https://github.com/apache/maven-shared-utils/pull/426
`Xpp3DomWriter.write` dereferences `dom` immediately, so a null argument already fails with a bare `NullPointerException` and no indication of which argument was wrong. `Objects.requireNonNull` names it, and a test pins the behaviour. The commit is [Elliotte Rusty Harold](https://github.com/elharo)'s, cherry-picked from the `fix/xpp3domwriter-null-dom` branch he pushed here on 2026-07-01 and never opened as a PR. Authorship is preserved, and the code is unchanged. Opening it because the fix is finished and 3.5.0 is close; happy to hand it back if he would rather carry it himself. No behaviour change beyond the message: the call threw `NullPointerException` before and still does. It also adds `Xpp3DomWriterTest`, which the class had none of. `Xpp3DomWriter` is deprecated in 3.5.0, so this is a diagnostics improvement on a class on its way out rather than new investment. Verified: `mvn -B verify` on JDK 17 -> Tests run: 788, Failures: 0, Errors: 0. Spotless clean. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
