gnodet-bot commented on code in PR #13094: URL: https://github.com/apache/maven/pull/13094#discussion_r3978894658
########## its/core-it-suite/src/test/resources/mng-8766-spi-workspace-reader/project/pom.xml: ########## @@ -0,0 +1,39 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.1.0"; root="true"> + + <groupId>org.apache.maven.its.mng8766</groupId> + <artifactId>test</artifactId> + <version>0.1</version> + <packaging>jar</packaging> + + <name>Maven Integration Test :: mng-8766</name> + <description>Verify that SPI WorkspaceReader is used for dependency resolution but not for plugin resolution.</description> Review Comment: 💡 Same stale description — the IT no longer verifies plugin resolution exclusion. ```suggestion <description>Verify that SPI WorkspaceReader is discovered and consulted for artifact resolution.</description> ``` ########## its/core-it-suite/src/test/resources/mng-8766-spi-workspace-reader/extension/pom.xml: ########## @@ -0,0 +1,57 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.1.0"; root="true"> + + <groupId>org.apache.maven.its.mng8766</groupId> + <artifactId>spi-workspace-reader</artifactId> + <version>0.1</version> + <packaging>jar</packaging> + + <name>Maven Integration Test :: spi-workspace-reader</name> + <description>SPI WorkspaceReader extension that opts out of plugin resolution</description> Review Comment: 💡 Stale description from the previous approach — the extension no longer "opts out of plugin resolution." The SPI now provides workspace artifact resolution, and cache invalidation is handled separately via `PluginRealmCache.invalidate()`. ```suggestion <description>SPI WorkspaceReader extension for IDE workspace artifact resolution</description> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
