elharo commented on code in PR #391:
URL:
https://github.com/apache/maven-shared-utils/pull/391#discussion_r3506159587
##########
src/main/java/org/apache/maven/shared/utils/xml/XMLEncode.java:
##########
@@ -109,7 +109,13 @@ static void xmlEncodeTextAsPCDATA(String text, boolean
forAttribute, char quoteC
break;
default:
- n.append(c);
+ if (c < 0x20 && c != 0x09 && c != 0x0A && c != 0x0D) {
Review Comment:
This only works in XML 1.1. Perhaps we should thrown an exception in this
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
