slachiewicz commented on issue #390: URL: https://github.com/apache/maven-shared-utils/issues/390#issuecomment-5631310091
Direction: the fix is #391, which rejects the characters instead of encoding them, since a numeric reference for U+0001 is not valid XML 1.0 either. It is held on one gap: text longer than 12 characters without `]]>` takes the CDATA branch in `xmlEncodeText` before the new check runs, so the control character still reaches the output. Once that check moves ahead of the CDATA branch the PR is mergeable; the exception type (`IOException` versus `IllegalArgumentException`) is the only open question left there. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
