slachiewicz commented on issue #274: URL: https://github.com/apache/maven-shared-utils/issues/274#issuecomment-5631308683
Direction: the stream-closing behaviour stays as documented for the 3.x line. #424 tried to stop closing and was closed after review: the javadoc has promised the change "in a future release" for years, but consumers written against that promise are the ones who would leak, and nothing in the signature warns them. The change belongs to a major version, with the `InputStream` overloads either dropped or made non-closing at the same time. The review of #424 also pointed at the larger defect: `loadProperties(InputStream)` and `loadOptionalProperties(InputStream)` swallow `IOException` and return empty properties, so an I/O failure is indistinguishable from an empty file. That is the part worth fixing first, and it is also a behaviour change, so it wants its own issue rather than riding on this one. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
