renechoi opened a new pull request, #13099:
URL: https://github.com/apache/maven/pull/13099

   On a recursive reference `DefaultModelInterpolator` records an ERROR and 
returns `null`. The transformer writes it into `List<String>` fields such as 
`build/filters` (its `Properties` branch already guards), and the immutable 
constructor calls `List.copyOf`, so the build dies with a bare NPE that hides 
the collected error:
   
   ```
   java.lang.NullPointerException
    at java.util.List.copyOf(List.java:1193)
    at o.a.m.model.v4.MavenTransformer.transformBuild(:514)
    at o.a.m.impl.model.DefaultModelInterpolator.interpolateModel(:111)
   ```
   
   Returning the original text fixes it at the source instead of in the 
generated template, and matches `DecryptingSettingsTransformer` and MNG-8174 
(#12932), which covered Maven 3 only.
   
   The new test fails on master with that NPE. Full `mvn test`: 3136 tests, 0 
failures. Can open a `maven-4.0.x` backport.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to