lprimak commented on PR #3470:
URL: https://github.com/apache/maven-surefire/pull/3470#issuecomment-5640128396

   With this PR, I get the below output.
   
   I would still say that's "too many times"
   I think that the extension should only be called once, and it's getting 
called 3 times now (was 4 times before this fix)
   
   ```
   [INFO] --- surefire:3.6.1-SNAPSHOT:test (default-test) @ 
maven-testng-reproducer ---
   [INFO] Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
   [INFO] TestNG is present. Adding per default 
org.junit.support:testng-engine:1.1.0
   [INFO] 
   [INFO] -------------------------------------------------------
   [INFO]  T E S T S
   [INFO] -------------------------------------------------------
   MyTestNGExtension: onStart called for suite: Command line suite
   MyTestNGExtension: onFinish called for suite: Command line suite
   MyTestNGExtension: onStart called for suite: Command line suite
   MyTestNGExtension: onFinish called for suite: Command line suite
   [INFO] Running com.flowlogix.maven.jupiter.JupiterTest
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 
s -- in com.flowlogix.maven.jupiter.JupiterTest
   MyTestNGExtension: onStart called for suite: Command line suite
   [INFO] Running com.flowlogix.maven.testng.NextGenTest
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 
s -- in com.flowlogix.maven.testng.NextGenTest
   MyTestNGExtension: onFinish called for suite: Command line suite
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to