cstamas commented on code in PR #2135:
URL: https://github.com/apache/maven-resolver/pull/2135#discussion_r3993563893
##########
maven-resolver-spi/src/main/java/org/eclipse/aether/spi/remoterepo/RepositoryKeyFunctionFactory.java:
##########
@@ -32,10 +33,34 @@ public interface RepositoryKeyFunctionFactory {
*
* @param session The repository session, must not be {@code null}.
* @return The repository key function.
- * @see #repositoryKeyFunction(Class, RepositorySystemSession, String,
String)
+ * @see #repositoryKeyFunction(Class, RepositorySystemSession, String,
String[])
* @see
org.eclipse.aether.ConfigurationProperties#REPOSITORY_SYSTEM_REPOSITORY_KEY_FUNCTION
*/
- RepositoryKeyFunction systemRepositoryKeyFunction(RepositorySystemSession
session);
+ default RepositoryKeyFunction
systemRepositoryKeyFunction(RepositorySystemSession session) {
+ return repositoryKeyFunction(
+ RepositoryKeyFunctionFactory.class,
+ session,
+
ConfigurationProperties.DEFAULT_REPOSITORY_SYSTEM_REPOSITORY_KEY_FUNCTION,
+
ConfigurationProperties.REPOSITORY_SYSTEM_REPOSITORY_KEY_FUNCTION);
+ }
+
+ /**
+ * Returns system-wide tracking repository key function.
+ *
+ * @param session The repository session, must not be {@code null}.
+ * @return The repository key function.
+ * @see #repositoryKeyFunction(Class, RepositorySystemSession, String,
String[])
+ * @see
org.eclipse.aether.ConfigurationProperties#REPOSITORY_SYSTEM_REPOSITORY_KEY_FUNCTION
+ * @since 2.0.23
+ */
+ default RepositoryKeyFunction
trackingRepositoryKeyFunction(RepositorySystemSession session) {
+ return repositoryKeyFunction(
+ RepositoryKeyFunctionFactory.class,
+ session,
+
ConfigurationProperties.DEFAULT_REPOSITORY_TRACKING_REPOSITORY_KEY_FUNCTION,
+
ConfigurationProperties.REPOSITORY_TRACKING_REPOSITORY_KEY_FUNCTION,
+
ConfigurationProperties.REPOSITORY_SYSTEM_REPOSITORY_KEY_FUNCTION);
Review Comment:
Fixed, now key type enum is used in `Key.of` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
