gnodet opened a new pull request, #402: URL: https://github.com/apache/maven-archiver/pull/402
Fixes https://github.com/apache/maven-jar-plugin/issues/596 Projects without `module-info.java` that configure `Automatic-Module-Name` in `<archive><manifestEntries>` using a property derived from the artifactId (e.g. `${project.groupId}.${project.artifactId}`) can produce invalid JPMS module names when the artifactId contains hyphens. This previously caused a hard build failure with `ManifestException: Invalid automatic module name`. This change downgrades the error to a warning and removes the invalid attribute from the manifest, allowing the build to succeed. The `Automatic-Module-Name` is purely advisory for non-modular JARs and should not break builds. Affected projects include: - `geronimo-arthur` — derived name `org.apache.geronimo.arthur.integration-test` - `karaf-winegrower` — derived name `org.apache.winegrower.cepages.winegrower-cepage-osgi-cdi` Changes: - `MavenArchiver.java`: Replace `ManifestException` throw with `LOGGER.warn()` + attribute removal for invalid module names - `MavenArchiverTest.java`: Updated existing test to verify warning behavior; added new test for hyphenated module name scenario -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
