ascheman commented on PR #996: URL: https://github.com/apache/maven-enforcer/pull/996#issuecomment-5659869615
Addressed the remaining Copilot review points in 01f885f: - **JavaModuleInfoReader** — a present but unparseable `module-info.class` (valid magic + readable class-file version) now throws `IOException` instead of returning `null`, so a corrupt descriptor surfaces as a build error rather than silently passing the rule. - **RequireMinimalExports** — `setInternalPackagePattern(null)` is now ignored (keeps the default) so `execute()` never calls `Pattern.compile(null)`; and `allowedExports` is looked up via a `HashSet` (O(1)) instead of `List.contains()` inside the export loop. - **requireMinimalExports.md.vm** — documented that `internalPackagePattern` is matched against the whole package name (`Matcher.matches()`). - **JavaModuleInfoReaderTest** — `assertTrue(!x)` → `assertFalse(x)`. The earlier Copilot points (Set iteration order, the Java 9+ runtime guard gated on module-info presence, the IT comment, and the fixture output path) were handled in previous commits. Resolving those threads. Local `enforcer-rules` unit tests are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
