[ 
http://jira.codehaus.org/browse/DOXIA-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lukas Theussl updated DOXIA-145:
--------------------------------

    Attachment: DOXIA-145.patch

After some more discussion, here is my proposition: only DefaultDoxia extends 
AbstractLogEnabled. Sink, parser and macro have independent instances of a 
logger that they inherit from a super interface (note: api changes!) so in 
principle they can be set independently. In practice it's the parser that 
should propagate its logger to the sink and macros that it's using. I have put 
the logging package into a separate module to avoid a circular dependency, 
since both sink and parser should be LogEnabled.

I have tested by adding a simple xdoc to the site-renderer test that contains 
an invalid element, one can see that the  plexus logger injected in 
DefaultDoxia is used indeed.

> Adding logger feature
> ---------------------
>
>                 Key: DOXIA-145
>                 URL: http://jira.codehaus.org/browse/DOXIA-145
>             Project: Maven Doxia
>          Issue Type: New Feature
>          Components: Core, Modules, Sink API
>            Reporter: Vincent Siveton
>             Fix For: 1.0-beta-1
>
>         Attachments: DOXIA-145.patch
>
>
> Doxia needs to have logger capability insides

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to