gnodet-bot commented on code in PR #13158:
URL: https://github.com/apache/maven/pull/13158#discussion_r4029922223
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1696,25 +1697,38 @@ private void addActivePomProfiles(String modelId,
List<Profile> activePomProfile
private List<Profile> getActiveProfiles(
Review Comment:
test 1697
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1696,25 +1697,38 @@ private void addActivePomProfiles(String modelId,
List<Profile> activePomProfile
private List<Profile> getActiveProfiles(
Collection<Profile> interpolatedProfiles,
DefaultProfileActivationContext profileActivationContext) {
Review Comment:
test 1698
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1696,25 +1697,38 @@ private void addActivePomProfiles(String modelId,
List<Profile> activePomProfile
private List<Profile> getActiveProfiles(
Collection<Profile> interpolatedProfiles,
DefaultProfileActivationContext profileActivationContext) {
if (isBuildRequestWithActivation()) {
Review Comment:
test 1699
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1696,25 +1697,38 @@ private void addActivePomProfiles(String modelId,
List<Profile> activePomProfile
private List<Profile> getActiveProfiles(
Collection<Profile> interpolatedProfiles,
DefaultProfileActivationContext profileActivationContext) {
if (isBuildRequestWithActivation()) {
- Collection<Profile> eligibleProfiles = interpolatedProfiles;
if (externalOrigin) {
Review Comment:
test 1700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
