gnodet commented on code in PR #13036:
URL: https://github.com/apache/maven/pull/13036#discussion_r4047390450
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Node.java:
##########
@@ -40,39 +40,98 @@
@Provider
public interface Node {
+ /**
+ * Returns the artifact for this node.
+ *
+ * @return artifact for this node, or {@code null} if none
+ */
+ @Nullable
+ Artifact artifact();
+
+ /**
+ * Returns the dependency for this node.
+ *
+ * @return dependency for this node, or {@code null} if none
+ */
+ @Nullable
+ Dependency dependency();
+
+ /**
+ * Gets the child nodes of this node.
+ *
+ * @return the child nodes of this node, never {@code null}
+ */
+ @Nonnull
+ List<Node> children();
+
+ /**
+ * Returns the remote repositories of this node.
+ *
+ * @return repositories of this node, never {@code null}
+ */
+ @Nonnull
+ List<RemoteRepository> remoteRepositories();
+
+ /**
+ * Returns the remote repository from which this artifact was downloaded,
if known.
+ *
+ * @return an {@code Optional} containing the repository, or empty if not
available (e.g. local artifact or root node)
+ */
+ @Nonnull
+ Optional<RemoteRepository> repository();
Review Comment:
The Javadoc was corrected in 45f2a0860a (the previous commit):
`repository()` now documents `@return an Optional containing the repository, or
empty if not available (e.g. local artifact or root node)`, which matches the
upstream `getRepository()` wording.
##########
api/maven-api-core/src/main/java/org/apache/maven/api/LocalRepository.java:
##########
@@ -46,6 +46,23 @@
@Immutable
public interface LocalRepository extends Repository {
+ /**
+ * Returns the path of this local repository.
+ *
+ * @return the path, never {@code null}
+ */
@Nonnull
- Path getPath();
+ Path path();
+
+ /**
+ * Returns the path of this local repository.
+ *
+ * @return the path, never {@code null}
+ * @deprecated Use {@link #path()} instead.
+ */
+ @Nonnull
Review Comment:
Fixed in f0701c6f49.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
