gnodet-bot commented on code in PR #12694: URL: https://github.com/apache/maven/pull/12694#discussion_r4048663883
########## api/maven-api-core/src/main/java/org/apache/maven/api/build/report/LogEvent.java: ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.build.report; + +import java.time.Instant; + +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.annotations.Immutable; +import org.apache.maven.api.annotations.Nonnull; +import org.apache.maven.api.annotations.Nullable; + +/** + * A structured log event captured during the build. + * <p> + * Each event carries the log level, timestamp, message, and optionally + * the logger name and a stack trace. This replaces raw log line strings + * in the build report, enabling programmatic filtering by level and + * correlation by timestamp. + * <p> + * Events originating from the Maven Log API or from JUL + * ({@code java.util.logging}) carry additional source metadata: the + * source class name, source method name, and thread identifier. + * For Log API events the source class name is the mojo implementation + * FQCN; for JUL events it comes from {@code LogRecord}. Events from + * direct SLF4J logging have these fields set to {@code null}. + * + * @since 4.1.0 + */ +@Experimental +@Immutable +public interface LogEvent { + + /** + * When this log event was produced (wall-clock time). + * + * @return the event instant, never {@code null} + */ + @Nonnull + Instant timestamp(); + + /** + * The severity level of this log event. + * + * @return the log level, never {@code null} + */ + @Nonnull + LogLevel level(); + + /** + * The log message, without level prefix or timestamp formatting. + * + * @return the formatted message, never {@code null} Review Comment: **[low] Javadoc copy-paste: `@return` says "the formatted message" but this is `message()`, not `formattedMessage()`.** The field comment says "The log message, without level prefix or timestamp formatting" — the `@return` tag should match: ```suggestion * @return the log message, never {@code null} ``` ########## impl/maven-core/src/test/java/org/apache/maven/internal/impl/DefaultLogTest.java: ########## @@ -51,13 +54,31 @@ void warnWithSupplierAndThrowableDelegatesToWarn() { verify(mockLogger).warn("warning message", ex); } + /** + * Verify that Log API metadata is set during the log call and + * cleared afterwards — no leakage across calls. + */ + @Test + void logApiMetadataIsClearedAfterCall() { + Logger mockLogger = mock(Logger.class); + when(mockLogger.isInfoEnabled()).thenReturn(true); + when(mockLogger.getName()).thenReturn("com.example.MyMojo"); + + DefaultLog log = new DefaultLog(mockLogger); + log.info("test message"); + + // After the call completes, metadata should be cleared + assertNull(DefaultLog.getLogApiMetadata(), "Log API metadata should be cleared after the log call"); Review Comment: **[low] `logApiMetadataIsClearedAfterCall()` is trivially true — never exercises the cleanup path** The test calls `log.info("test message")` without activating report capture. Inside `withMetadata()`, `ProjectBuildLogAppender.hasReportCapture()` returns `false`, so it takes the `else` branch and calls `logAction.run()` directly — `LOG_API_METADATA.set()` and `.remove()` are never called. `assertNull(getLogApiMetadata())` is always true whether or not the `finally { remove() }` block works. To actually test the cleanup path, activate capture before the call: ```java ProjectBuildLogAppender.setReportCapture(consumer -> {}); try { log.info("test message"); assertNull(DefaultLog.getLogApiMetadata(), "ThreadLocal must be cleared after call"); } finally { ProjectBuildLogAppender.setReportCapture(null); } ``` Or use a `@TempDir`-based `MockBuildEventListener` if that's how capture is activated in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
