gnodet commented on PR #13194:
URL: https://github.com/apache/maven/pull/13194#issuecomment-5739924877
All review threads resolved. For the record on the version-range constructor
discussion:
`AbstractMavenIntegrationTestCase` in this codebase
(`its/core-it-support/maven-it-helper`) exposes only `protected
AbstractMavenIntegrationTestCase() {}` — there is no `String versionRangeStr`
overload. The sibling tests cited as counter-evidence (`MavenITgh13004`,
`MavenITgh13068`) have no constructor at all and compile fine without one. The
bot review was based on a hallucination about the API.
Both implementation findings are addressed: CI-friendly property lookup now
covers POM properties (the actual fix), and the `pomProperties` map is keyed by
`groupId:artifactId:property` to avoid cross-module collision in reactor
builds. CI is green across all 19 matrix jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
