gnodet-bot commented on code in PR #13196:
URL: https://github.com/apache/maven/pull/13196#discussion_r4052487198
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -1350,7 +1350,9 @@ private void mismatchRelativePathAndGA(Model childModel,
Parent parent, String g
+ (maven3Mode
? ". Please verify your project structure."
: ". Correct the <relativePath> value or
remove it to let Maven resolve the parent"
- + " from the repository.");
+ + " from the repository."
+ + " If this POM was generated by a
build tool (e.g. maven-shade-plugin),"
+ + " upgrade that tool or use
--maven3-personality as a temporary workaround.");
Review Comment:
⚠️ **Wrong workaround syntax — `--maven3-personality` is not a valid CLI
flag.**
The maven3 personality is activated via a system property
(`-Dmaven.maven3Personality=true`), not a `--maven3-personality` command-line
switch. `MavenOptions` has no such option; using `--maven3-personality` on the
CLI will produce an "Unknown option" error, making the hint actively harmful to
users.
The constant is `Constants.MAVEN_MAVEN3_PERSONALITY =
"maven.maven3Personality"`.
```suggestion
+ " from the repository."
+ " If this POM was generated by a
build tool (e.g. maven-shade-plugin),"
+ " upgrade that tool or use
-Dmaven.maven3Personality=true as a temporary workaround.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
