slachiewicz opened a new pull request, #1206: URL: https://github.com/apache/maven-plugin-tools/pull/1206
Port of #1202 to master, plus the reason the port could not be verified as-is. **#1202:** `GoalRenderer` rendered `requiresDependencyCollection` only for an `ExtendedMojoDescriptor`, but the report reads descriptors back from `plugin.xml` as plain `MojoDescriptor`s, so the attribute never appeared. The gate goes; `MojoDescriptor.getDependencyCollectionRequired()` carries the value. Fixes #832 on master. **Second commit:** on master the fix still rendered nothing, and neither did `requiresDependencyResolution`, direct invocation or online mode. plugin-tools 4.x writes the Maven 4 element names into `plugin.xml` (`dependencyResolution`, `dependencyCollection`, `directInvocationOnly`, `projectRequired`, `onlineRequired`), while the report's own `PluginDescriptorBuilder` copy only read the Maven 3 names (`requiresDependencyResolution`, `requiresDirectInvocation`, `requiresOnline`, …). Every plugin built with plugin-tools 4.x lost those five attributes on its goal pages. The builder now accepts both spellings. Verified: `plugin-report-400` IT asserts both dependency scopes, direct invocation and online mode on `noop-mojo.html`; all 12 report ITs pass. The scope assertions fail without either commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
