slachiewicz opened a new pull request, #772: URL: https://github.com/apache/maven-indexer/pull/772
Stacked on #771. jMock was the last dependency pulling Hamcrest onto the test classpath, so this also removes the hamcrest pin #771 had to keep. The three indexer-reader tests mock two-method interfaces and now use plain fakes, leaving that module without a mock framework; DefaultIndexUpdaterTest keeps its interaction checks and moves to Mockito, with `verifyNoMoreInteractions(ignoreStubs(..))` standing in for jMock's strict mockery. indexer-cli declared jMock without using it. Two `never(tempContext).getIndexDirectoryFile()` expectations are not carried over: an earlier `allowing()` on the same method matched first in jMock, so they never applied and the call does happen. Verified: mvn -P run-its verify on indexer-reader, indexer-core, indexer-cli → BUILD SUCCESS, 225/16/7 tests as on master; dependency:tree shows no org.hamcrest or org.jmock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
