laeubi commented on issue #186: URL: https://github.com/apache/maven-verifier/issues/186#issuecomment-5763341293
The migration guide currently claims that `verifier.verifyErrorFreeLog()` can be replaced with `result.success()` what is not really true. e.g. if I log an error from a mojo this will never have an influence on the return code but `verifier.verifyErrorFreeLog()` will still fail! Also the executor seem to require a try/catch while the verifier could be just released so the example `new Verifier(baseDir)` can be replaced by `ExecutorRequest.mavenBuilder().cwd(baseDir).build()` seems also only be true whenever one does not need further customization (while the verifier can be customized even after execute it once). I just wanted to mention this as I noticed it with checking Tychos heavy use of maven-verifier (while we where not able to fully [migrate even to 2.0](https://github.com/eclipse-tycho/tycho/pull/1842)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
