gnodet commented on PR #11029:
URL: https://github.com/apache/maven/pull/11029#issuecomment-5764197575
All review comments addressed in the latest push:
**@copilot-pull-request-reviewer:**
- Fixed invalid `-ea:pkg1:pkg2` argLine → split into
`-ea:org.codehaus.classworlds... -ea:org.codehaus.plexus.classworlds...`
- Fixed Javadoc typos in `ConfigurationException` ("configuraton"/"occured")
- Fixed `LICENSE.vm` to also map `maven-api-classworlds` → `boot/` directory
- Fixed JLine dual-copy: added `org.jline:*` exclusion from the `lib/`
dependencySet so JLine only lands in `lib/modules/`
**@desruisseaux:**
- Added comprehensive Javadoc to `applyModuleAccessDescriptors` explaining
the purpose, direction of access (named boot-layer module → plugin unnamed
module, not the reverse), file format, and why `module-info.java` cannot be
used instead
- The `ClassRealm` API question: no further action needed — the discussion
in the thread explains why ClassRealms and JPMS `ModuleLayer`s are
complementary, not duplicates
**Fragile classloader lookups (gnodet-bot):**
- `getEffectiveClassLoader`: replaced `iterator().next().getClassLoader()`
with `layer.findLoader(anyModuleName)` via `stream().findFirst()`
- `close()`: same fix — replaced loop-with-break with
`stream().findFirst().ifPresent(...)`
- `CacheKey` missing `modular` flag: added field + hash + equals; kept old
constructor and added `default` overload on the `PluginRealmCache` interface to
preserve binary compatibility (japicmp was catching this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
