gnodet-bot commented on code in PR #13238:
URL: https://github.com/apache/maven/pull/13238#discussion_r4069616043
##########
pom.xml:
##########
@@ -1274,6 +1274,16 @@ under the License.
<modules>
<module>its</module>
</modules>
+ <properties>
+ <!-- Pass the actual Maven version being built to the ITs reactor, so
that
+ the IT support plugins (e.g. maven-it-plugin-bootstrap) resolve
+ maven-plugin-api from the local repository rather than from the
remote
+ Apache Snapshots repository. Without this, maven-plugin-tools
infers
+ requiredMavenVersion from the timestamped snapshot version
resolved
+ remotely (e.g. 4.0.0-20260921.041318-545), which then fails the
version
+ check against the locally built Maven (self-reported as
4.0.0-SNAPSHOT). -->
+ <maven-version>${project.version}</maven-version>
Review Comment:
⚠️ **Propagation concern:** `its/pom.xml` declares
`<parent>org.apache:apache</parent>`, not the Maven root POM. Profile
`<properties>` are model-level and only inherited via the `<parent>` chain —
not via `<modules>` inclusion in the reactor. This property override in root's
`run-its` profile should not reach `its/`'s effective POM, which will still
resolve `maven-version=4.0.0-SNAPSHOT` from its own `<properties>` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
