belingueres opened a new pull request, #666:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/666
A managed dependency that declares no version (e.g. one only used to
override the scope or exclusions of a transitive dependency) used to make the
dependency-management report fail entirely with "The version cannot be empty".
DependencyManagementReport now resolves the project's dependencies via
ProjectDependenciesResolver - the same core component Maven's own lifecycle
uses to satisfy requiresDependencyResolution - and hands the resolved graph to
DependencyManagementRenderer. When a managed entry has no declared version, its
resolved version is looked up there and rendered in parentheses, e.g.
"(0.0.1)", to mark it as inferred rather than explicitly declared.
A note is now also rendered under each scope's introduction paragraph, but
only when that scope actually contains a resolved (parenthesized) entry,
explaining what the parentheses notation means. The message is added to
project-info-reports.properties and its Spanish translation.
Adds the MPIR-397 IT, and extends MPIR-362's verify.groovy to assert the
note is absent when no version needed to be resolved.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
