goutamadwant opened a new pull request, #1507: URL: https://github.com/apache/maven-release/pull/1507
Fixes #1477. With `checkModificationExcludes` set to `**/pom.xml`, `release:prepare` can report success while leaving the release tag at the SNAPSHOT version and creating no SCM commits. The exclusion was also being applied to version mapping, POM rewriting, and commits. When the configured patterns match every reactor POM, this change applies them only to the initial modification check. Release preparation still updates and commits the POMs. Existing exclusions that select only some reactor projects keep their current behavior. The three release phases now use the same per-invocation project selection, so exclusions do not carry over between executions. Validation: - Added single- and multi-module regression tests for version mapping and POM rewriting, plus an SCM commit regression test. The new tests failed before the fix. - `mvn verify` passed. - `mvn -Prun-its verify` passed (51 integration cases passed, four skipped). - In a local Git reproducer using the built 3.3.2-SNAPSHOT plugin, `release:prepare` created release and development commits; the tag contains version `1.0` and the working POM contains `1.1-SNAPSHOT`. When POM changes are intentionally ignored by the modification check, matching all reactor POMs now allows those changes to be included in the release commits. Checklist: - [x] This pull request addresses one issue. - [x] The description explains what changed, how, and why. - [x] The commit has a meaningful subject and body. - [x] Added regression tests that fail without the production fix. - [x] `mvn verify` passed. - [x] `mvn -Prun-its verify` passed. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0). - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
