elharo commented on code in PR #158:
URL: https://github.com/apache/maven-shared-jar/pull/158#discussion_r4082169135
##########
src/main/java/org/apache/maven/shared/jar/identification/exposers/TextFileExposer.java:
##########
@@ -64,13 +64,15 @@ private List<String> findTextFileVersions(JarAnalyzer
jarAnalyzer) {
try (InputStream is = jarAnalyzer.getEntryInputStream(entry)) {
BufferedReader br = new BufferedReader(new
InputStreamReader(is));
Review Comment:
@copilot what files are we reading here? what's the rules for encoding of
those files? are they supposed to be in UTF-8 or ASCII or 8859-1 or anything at
all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
