efegokdemir opened a new pull request, #440:
URL: https://github.com/apache/maven-shared-utils/pull/440

   ## Summary
   
   Fixes #274 by making the InputStream overloads of PropertyUtils leave 
caller-owned streams open.
   
   ## Changes
   
   - Stop wrapping supplied streams in try-with-resources in 
`loadProperties(InputStream)` and `loadOptionalProperties(InputStream)`.
   - Update the API documentation to state that callers retain close 
responsibility.
   - Add regression coverage for both overloads using tracking streams.
   
   ## Testing
   
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -Dtest=PropertyUtilsTest test` 
— PASS (14 tests).
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -Prun-its verify` — PASS (804 
tests, 19 skipped; this project does not define the `run-its` profile, so Maven 
reported it as not activated).
   - `git diff --check` — PASS.
   
   ## Notes
   
   The URL and File overloads continue to close streams they create themselves. 
AI assistance was used during implementation; the complete diff and test 
results were reviewed before submission. No overlapping open PR was found 
during the final duplicate check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to