slawekjaranowski commented on code in PR #603:
URL: https://github.com/apache/maven-jar-plugin/pull/603#discussion_r4085004180
##########
pom.xml:
##########
@@ -227,6 +227,12 @@
<goal>package</goal>
</goals>
<showErrors>true</showErrors>
+ <filterProperties>
+ <!-- Expose the inherited property so
@version.maven-surefire-plugin@ tokens
+ in IT pom.xml files are replaced at filter time
(inherited properties
+ are not visible to the invoker's POM filtering step). -->
+
<version.maven-surefire-plugin>${version.maven-surefire-plugin}</version.maven-surefire-plugin>
+ </filterProperties>
Review Comment:
all project properties should be available for filtering, we don't need
redefine the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
