efegokdemir opened a new pull request, #1408:
URL: https://github.com/apache/maven-scm/pull/1408

   ## Summary
   
   Remove the broad `Throwable` catch from the Mercurial provider's URL parsing 
path.
   
   The `File` constructor did not provide useful filename validation here, 
while catching `Throwable` could swallow serious JVM conditions. Local-path 
handling continues to follow the existing provider flow.
   
   ## Changes
   
   - Remove the ineffective `try/catch (Throwable)` from `HgScmProvider`.
   - Leave protocol validation and repository construction unchanged.
   
   ## Testing
   
   - `mvn -pl maven-scm-providers/maven-scm-provider-hg -am 
-Dspotless.skip=true -DskipTests=false test` — passed (8 tests in the Mercurial 
provider; reactor build successful).
   - Checkstyle, Apache RAT, compilation, and `git diff --check` — passed.
   - The repository Spotless formatter could not run under the available JDK 
because its existing Palantir formatter fails with `NoSuchFieldError` across 
unchanged Maven SCM files.
   
   ## Notes
   
   This contribution was prepared with AI assistance and reviewed against the 
existing provider implementation and test conventions.
   
   Fixes #1301
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to