gnodet-bot commented on code in PR #424:
URL:
https://github.com/apache/maven-resources-plugin/pull/424#discussion_r4093233721
##########
pom.xml:
##########
@@ -175,16 +165,27 @@ under the License.
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- <version>${guiceVersion}</version>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-testing</artifactId>
+ <version>${mavenVersion}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
Review Comment:
⚠️ **Redundant declaration.** `maven-testing` already brings
`junit-jupiter-api` as a transitive dependency (visible in its POM). This
explicit entry is now dead weight — it will silently override the version
managed by `maven-testing`'s BOM if they ever diverge. Drop it.
```suggestion
```
##########
pom.xml:
##########
@@ -175,16 +165,27 @@ under the License.
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- <version>${guiceVersion}</version>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-testing</artifactId>
+ <version>${mavenVersion}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.inject</groupId>
+ <artifactId>guice</artifactId>
+ <version>${guiceVersion}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
⚠️ **Redundant declaration.** `maven-testing` already brings
`com.google.inject:guice` as a transitive dependency. Keeping it explicit with
a pinned `${guiceVersion}` creates a version pinning risk: if `maven-testing`
upgrades guice, this pin silently downgrades it back. Drop the explicit entry
and let `maven-testing` manage the version.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
