gnodet commented on PR #563:
URL: https://github.com/apache/maven-jar-plugin/pull/563#issuecomment-5813569008

   Added the actual code fix in the latest commit: replaced 
`File.separatorChar` with a literal `'/'` in `AbstractJarMojo`. 
`FileSetManager.getIncludedFiles()` always returns forward-slash-separated 
paths regardless of the OS, so the prefix check must use `/` — JAR paths are 
also always forward-slash per the specification. The `java.io.File` import is 
no longer needed after the fix and has been removed.
   
   The IT (with `test.txt` under `META-INF/versions/9/`) is correct as-is: any 
file under `META-INF/versions/` triggers the detection, not just 
`module-info.class`. The fixture exercises the actual code path.
   
   The `withCloseable` and assertion message from the second commit are already 
in place.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to