gnodet commented on PR #561: URL: https://github.com/apache/maven-jar-plugin/pull/561#issuecomment-5815205328
The merge conflict in this PR is non-trivial — the `createArchive()` method that this PR modifies has been completely rewritten in `master` (now `createArchives()` using `ToolExecutor`/`FileCollector`). The broad `catch (Exception e)` this PR was targeting no longer exists in the refactored code, so the fix is effectively superseded. The PR would need a full rewrite to apply against current `master`, and given the refactoring, the problem it solves (issue #559) appears to be inherently addressed already. Closing this as superseded unless @elharo wants to rebase and verify whether any equivalent concern remains in the new code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
