gnodet commented on code in PR #405:
URL: https://github.com/apache/maven-filtering/pull/405#discussion_r4103054375
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -67,13 +67,63 @@ public class DefaultMavenResourcesFiltering implements
MavenResourcesFiltering {
public DefaultMavenResourcesFiltering(MavenFileFilter mavenFileFilter,
BuildContext buildContext) {
this.mavenFileFilter = requireNonNull(mavenFileFilter);
this.buildContext = requireNonNull(buildContext);
- this.defaultNonFilteredFileExtensions = new ArrayList<>(5);
+ this.defaultNonFilteredFileExtensions = new ArrayList<>();
+ // Images
this.defaultNonFilteredFileExtensions.add("jpg");
this.defaultNonFilteredFileExtensions.add("jpeg");
this.defaultNonFilteredFileExtensions.add("gif");
this.defaultNonFilteredFileExtensions.add("bmp");
this.defaultNonFilteredFileExtensions.add("png");
this.defaultNonFilteredFileExtensions.add("ico");
+ this.defaultNonFilteredFileExtensions.add("webp");
+ this.defaultNonFilteredFileExtensions.add("tif");
+ this.defaultNonFilteredFileExtensions.add("tiff");
+ this.defaultNonFilteredFileExtensions.add("svg");
Review Comment:
Good catch — SVG is XML/text so it doesn't belong in the binary list.
Removed in 5038171.
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -67,13 +67,63 @@ public class DefaultMavenResourcesFiltering implements
MavenResourcesFiltering {
public DefaultMavenResourcesFiltering(MavenFileFilter mavenFileFilter,
BuildContext buildContext) {
this.mavenFileFilter = requireNonNull(mavenFileFilter);
this.buildContext = requireNonNull(buildContext);
- this.defaultNonFilteredFileExtensions = new ArrayList<>(5);
+ this.defaultNonFilteredFileExtensions = new ArrayList<>();
Review Comment:
Applied in 5038171.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
