Tarun4201 commented on PR #13254:
URL: https://github.com/apache/maven/pull/13254#issuecomment-5834433213
Addressed the inaccuracy flagged in the
`compat/maven-compat/src/main/mdo/profiles.mdo` description (commit `17849a5`).
### What changed
The previous wording implied the compat selector suppresses external
`activeByDefault` profiles when `-P` is used — which is incorrect.
`compat/maven-model-builder`'s `DefaultProfileSelector` does **not** implement
that behaviour (its `else` branch unconditionally adds all non-POM
`activeByDefault` profiles with no deferred list and no
`anyProfileExplicitlyActivated` check).
**Old (inaccurate):**
```xml
<description>If set to true, this profile will be active by default unless
another profile is
explicitly activated via the command line {@code -P} / {@code
--activate-profiles} option.</description>
```
**New (accurate):**
```xml
<description>Flag specifying whether this profile is active as a default.
Note: unlike the Maven 4 implementation, this compat selector does not
suppress external activeByDefault profiles when -P is used.</description>
```
### Summary of all descriptions across the three mdo files
| File | Behaviour documented |
|---|---|
| | POM suppressed by any same-POM activation (explicit **or** condition
activator) |
| | External suppressed only by explicit ; **not** by condition activators
(intentional asymmetry) |
| | Legacy compat selector — does **not** suppress external at all; noted
explicitly |
No logic or test changes in this commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
