gnodet-bot commented on code in PR #611:
URL: https://github.com/apache/maven-jar-plugin/pull/611#discussion_r4108076570
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -122,6 +122,28 @@ public abstract class AbstractJarMojo implements
org.apache.maven.api.plugin.Moj
@Parameter
protected MavenArchiveConfiguration archive = new
MavenArchiveConfiguration();
+ /**
+ * Whether to add default implementation entries ({@code
Implementation-Title},
+ * {@code Implementation-Version}, {@code Implementation-Vendor}) to the
{@code MANIFEST.MF}.
+ * When set on the command line or via a system property, this overrides
the value configured
+ * inside {@code <archive><manifest><addDefaultImplementationEntries>}.
+ *
+ * @since 3.4.3
+ */
+ @Parameter(property = "maven.jar.manifest.addDefaultImplementationEntries")
Review Comment:
⚠️ `@since 3.4.3` — this version has never existed (releases go 3.4.0 →
3.4.1 → 3.4.2 → 3.5.0 → 3.5.1). Master is currently at `4.0.0-beta-2-SNAPSHOT`.
Same issue on the second parameter below (line 144).
If this is intended for backport to the 3.x branch (`3.5.2-SNAPSHOT`), use
`@since 3.5.2`. If it's master-only, use `@since 4.0.0-beta-2`.
```suggestion
* @since 3.5.2
```
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -122,6 +122,28 @@ public abstract class AbstractJarMojo implements
org.apache.maven.api.plugin.Moj
@Parameter
protected MavenArchiveConfiguration archive = new
MavenArchiveConfiguration();
+ /**
+ * Whether to add default implementation entries ({@code
Implementation-Title},
+ * {@code Implementation-Version}, {@code Implementation-Vendor}) to the
{@code MANIFEST.MF}.
+ * When set on the command line or via a system property, this overrides
the value configured
+ * inside {@code <archive><manifest><addDefaultImplementationEntries>}.
+ *
+ * @since 3.4.3
+ */
+ @Parameter(property = "maven.jar.manifest.addDefaultImplementationEntries")
Review Comment:
⚠️ `@since 3.4.3` — this version was never released. Tags went 3.4.0 → 3.4.1
→ 3.4.2 → 3.5.0. Since the PR targets `master` (4.0.0-beta-2-SNAPSHOT):
```suggestion
* @since 4.0.0-beta-2
```
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -122,6 +122,28 @@ public abstract class AbstractJarMojo implements
org.apache.maven.api.plugin.Moj
@Parameter
protected MavenArchiveConfiguration archive = new
MavenArchiveConfiguration();
+ /**
+ * Whether to add default implementation entries ({@code
Implementation-Title},
+ * {@code Implementation-Version}, {@code Implementation-Vendor}) to the
{@code MANIFEST.MF}.
+ * When set on the command line or via a system property, this overrides
the value configured
+ * inside {@code <archive><manifest><addDefaultImplementationEntries>}.
+ *
+ * @since 3.4.3
+ */
+ @Parameter(property = "maven.jar.manifest.addDefaultImplementationEntries")
+ private Boolean addDefaultImplementationEntries;
+
+ /**
+ * Whether to add default specification entries ({@code
Specification-Title},
+ * {@code Specification-Version}, {@code Specification-Vendor}) to the
{@code MANIFEST.MF}.
+ * When set on the command line or via a system property, this overrides
the value configured
+ * inside {@code <archive><manifest><addDefaultSpecificationEntries>}.
+ *
+ * @since 3.4.3
+ */
+ @Parameter(property = "maven.jar.manifest.addDefaultSpecificationEntries")
+ private Boolean addDefaultSpecificationEntries;
Review Comment:
⚠️ Same issue — `3.4.3` never existed:
```suggestion
* @since 4.0.0-beta-2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
