slachiewicz opened a new pull request, #781: URL: https://github.com/apache/maven-indexer/pull/781
Turns the modernizer check back on in indexer-core, indexer-cli and indexer-examples and fixes the 56 violations in main sources. Test classes stay excluded (`includeTestClasses=false`): they account for the other 180 violations, nearly all `java.io.File` constructors, and converting them is a separate mechanical change. Two places keep the old behaviour on purpose: - `ScanningRequest.getStartingDirectory` and `FileFetcher.getFile` join with `Path.of(parent, child)`, not `resolve`, since a sub-path such as `/org/slf4j/slf4j-api` would otherwise be read as absolute. - `FileFetcher.retrieve` still throws `FileNotFoundException` for a missing file, as `ResourceFetcher` documents; `DigesterUtils` still returns `null` for a missing or unreadable file. No public signatures change. Verified: `mvn verify -Prun-its` → modernizer runs in all 11 modules with 0 violations; 225 indexer-core tests, ITs and RAT pass. Fixes #591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
