slachiewicz opened a new pull request, #800: URL: https://github.com/apache/maven-indexer/pull/800
Runs `org.openrewrite.java.testing.junit5.JUnit5BestPractices` (rewrite-testing-frameworks 3.19.0) over the test sources: package-private test classes and methods, no `test` prefix on test method names, and direct assertions (`assertNull(x)` rather than `assertEquals(null, x)`). Corrected by hand where the recipe changed what a test checks: - `FullIndexNexusIndexerTest` overrides take the parent's new names and `@Override`; with the old names both versions ran (22 → 28 tests). - `AbstractIndexCreatorHelper.directory()` is `protected`, so `NEXUS4149TransferFormatTest` in another package can still override it. - `RemoteRepositorySearchBackendImplTest` keeps the whole search inside `assertThrows`; the recipe had moved the throwing call out of the lambda. - `assertTrue(x != null)` becomes `assertNotNull(x)`, not `assertNotSame(x, null)`. Verified: per-class test counts identical to master for all 72 test classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
