Tarun4201 commented on PR #13277: URL: https://github.com/apache/maven/pull/13277#issuecomment-5855838991
### Updates in latest commit (`b0314a42`) 1. **Dead Code Removed (`gnodet-bot` Finding 4)**: Removed the unused `_skip_next` initialization and check in `mvn` launcher script's `handle_args()`. 2. **Comment Clean-up**: Removed stale references to `m2.conf` from `mvn` launcher comments and updated `README.txt`. 3. **Custom Exception Type (`elharo` feedback)**: Introduced `MavenClappCling.ClappException` (subclass of `MavenException`) to represent tool loading, configuration, and invocation failures instead of raw `IOException`. Invalid tool names and path traversal attempts now throw `IllegalArgumentException`. Updated `MavenClappClingTest` unit tests accordingly. 4. **Developer Documentation (`elharo` feedback)**: Added a comprehensive third-party CLAPP developer guide at `api/maven-api-cli/src/site/markdown/clapp.md` and linked it from the Maven 4 CLI API site index (`index.md`), explaining directory layout, descriptor configuration, entry-point contract, classloading architecture, and execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
