rmannibucau commented on PR #356: URL: https://github.com/apache/maven-clean-plugin/pull/356#issuecomment-5859786048
@gnodet not sure what it does changes, if we do leak - and we do - and want to fix it, it is in core it belongs IMHO, clean can't be made aware of all of that nor if it changed. Typically the algo there is "any folder with target as single child", this is very fragile and will delete folder it shouldn't for ex - in particular cause it totally ignores the reactors cause the module is not more inside but also means it can visit folder with target dir which were always outside the reactor. At least core could ensure to put a `target/.reactor` with a timestamp or alike inside (or nothing but think some meta can help). Another issue is that a module which is "src+pom free" will be deleted (extensions enable to do that). So really it is bound to core to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
