UsmanEjaz10 opened a new pull request, #13290:
URL: https://github.com/apache/maven/pull/13290

   ### Summary of Changes
   Fixes [MNG-8092](https://issues.apache.org/jira/browse/MNG-8092) / GH 
#10859: Incorrect extension-in-reactor warning when a plugin module is excluded 
with `-pl` or other project filters.
   
   ### How & Why
   1. **How it was fixed**: Moved the extension validation call from `build()` 
(which ran prematurely on all initial reactor projects) into 
`reactorDependencyGraph()` right after all project trimming/exclusion steps 
(`trimProjectsToRequest`, `trimSelectedProjects`, `trimResumedProjects`, and 
`trimExcludedProjects`), evaluating only `activeProjects`.
   2. **Why approached this way**: Extension-in-reactor warnings are only valid 
for modules actually participating in the build; running the validation after 
reactor trimming ensures excluded or non-selected modules do not trigger 
false-positive warnings.
   3. **Refactoring**: Renamed the private method to 
`validateExtensionIsNotPartOfReactor` and simplified reactor key matching to a 
clean `Set<String>` lookup over active projects, backed by integration test 
coverage in `MavenITmng5572ReactorPluginExtensionsTest`.
   
   ### Verification
   - `mvn test -pl impl/maven-core -Dtest=DefaultGraphBuilderTest` (34/34 tests 
pass)
   - `mvn spotless:check -pl impl/maven-core` clean
   
   ---
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to