slawekjaranowski commented on PR #326:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/326#issuecomment-5884683340

   > **General:** The comment-discovery logic relies on `c.user?.type === 
'Bot'` to find the marker comment. If a caller overrides `GITHUB_TOKEN` with a 
PAT, the comment author becomes a regular user (`type: 'User'`) and discovery 
silently breaks — the job will post a duplicate comment on every run. Worth a 
code comment near the `existing = comments.find(...)` call, or in the Usage 
section of the caller template, warning that the default `GITHUB_TOKEN` must be 
used.
   
   We will use this action in our projects, with our control, so default 
`GITHUB_TOKEN` will be used.
   
   We can drop requirements that message must be owned by `Bot`, message marker 
should be enough. Even if someone will try to prepare such comment we will see 
it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to