efegokdemir commented on PR #1136: URL: https://github.com/apache/maven-compiler-plugin/pull/1136#issuecomment-5889649957
Applied the blocking consistency feedback in 05525cf. `amendincrementalCompilation` now keeps the existing `incrementalCompilation`-absent condition, clears the default aspects, and selects `NONE` for annotation processors, so `proc=only` and `proc=full` behave consistently without overriding explicit user configuration. I evaluated the `MODULES` optimization; this method does not have the modular-project context needed to select it without broadening the change. Added coverage for default `proc=full` and explicit `incrementalCompilation` with `proc=only`; the existing `proc=only` regression and CompilerStub cleanup remain intact. `mvn -Denforcer.skip=true -Dspotless.check.skip=true -Dspotless.apply.skip=true -Dspotless.skip=true -Dcheckstyle.skip=true -DskipITs -Dtest=CompilerMojoTestCase test` passed (18 tests), and `git diff --check` passed. The normal Spotless path remains incompatible with this local JDK due the existing palantir-java-format `JCTree$JCCompilationUnit.endPositions` error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
