elharo commented on code in PR #410:
URL: https://github.com/apache/maven-archiver/pull/410#discussion_r4144259357
##########
src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java:
##########
@@ -723,7 +723,16 @@ private static boolean isNumeric(String str) {
return false;
}
- for (char c : str.toCharArray()) {
+ int start = 0;
+ if (str.charAt(0) == '-') {
+ if (str.length() == 1) {
+ return false; // lone "-" is not numeric (used as disable
sentinel in POM inheritance)
+ }
+ start = 1;
Review Comment:
I don't get it. Doesn't this just throw away an initial minus? The tests
pass so there must be something I'm not seeing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
