slachiewicz commented on issue #13302: URL: https://github.com/apache/maven/issues/13302#issuecomment-5913796855
### maven-shared-jar PR: apache/maven-shared-jar#182. Status: **ported**, 4.0.0-SNAPSHOT, Java 17. Verified locally: `mvn verify` with Maven 4.0.0-rc-7, JDK 21 → 91 tests before and after, 0 failures; spotless clean. **Public API changes** - `RepositoryHashSearch.searchFileHash`/`searchBytecodeHash` (and `EmptyRepositoryHashSearch`): `List<org.apache.maven.artifact.Artifact>` → `List<org.apache.maven.api.Artifact>`. - `EmbeddedMavenModelExposer` gains an injected `ModelXmlFactory` and reads the POM into the immutable v4 `Model`. - `@Named`/`@Singleton`/`@Inject` move from `javax.inject` to `org.apache.maven.api.di`, so Sisu no longer discovers these components; they cannot be injected under Maven 3. - `JarAnalyzer`, `JarData`, `JarClasses*`, `JarIdentification*` unchanged. **Gaps** - `maven-shared-components` parent sets `<proc>none</proc>`, so the `maven-api-di` index processor never runs; `META-INF/maven/org.apache.maven.api.di.Inject` is maintained by hand (as maven-filtering does). A new `@Named` class missing from it fails with "No binding". - `ModelXmlFactory` is implemented only in `maven-impl`, so the model exposer needs a Maven 4 container; the v4 `MavenStaxReader` lives in `maven-support`, which is not API. **Consumers that break:** maven-project-info-reports-plugin (`DependenciesReport` injects `JarClassesAnalysis`; `Dependencies`, `DependenciesRenderer` use unchanged types). It compiles, but under Maven 3 the component is no longer found. **Improvements:** drops `javax.inject`, `sisu-maven-plugin`, `plexus-xml`, `maven-model`, `maven-artifact`. **Recommendation:** port for Maven 4 plugins; keep a 3.x line while project-info-reports runs on Maven 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
