efegokdemir commented on code in PR #13251:
URL: https://github.com/apache/maven/pull/13251#discussion_r4155650416
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/goals/InferenceStrategy.java:
##########
@@ -159,6 +159,14 @@ public UpgradeResult doApply(UpgradeContext context,
Map<Path, Document> pomMap)
return new UpgradeResult(processedPoms, modifiedPoms, errorPoms);
}
+ private static void logInferenceResult(UpgradeContext context, String
description) {
+ if (context.isDryRun()) {
+ context.action(description + " would be applied");
+ } else {
+ context.success(description + " applied");
+ }
+ }
+
/**
* Applies limited parent-related inference optimizations for Maven 4.0.0+
models.
* Removes redundant child groupId/version that can be inferred from
parent.
Review Comment:
The current head already uses the inherited logChange helper directly; the
duplicate private helper is absent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
