gnodet opened a new pull request, #13335: URL: https://github.com/apache/maven/pull/13335
## Problem The new license declaration check fires for Apache committers whose GitHub org membership is **private**. GitHub uses different `author_association` values: - `MEMBER` — org member with public membership - `COLLABORATOR` — committer/member with private org membership (**most Apache committers**) - `OWNER`, `CONTRIBUTOR`, etc. The `if:` condition in the reusable workflow (`maven-gh-actions-shared`) correctly lists `OWNER` and `MEMBER` as skip targets, but was missing `COLLABORATOR`. Additionally, `github.event.pull_request` context is **not reliably propagated** into reusable workflows called via `workflow_call`, so the condition there doesn't work at all. ## Fix Move the `if:` guard to the **caller level** (`apache/maven`'s `pr-check.yml`), where `github.event.pull_request` is fully available, and add `COLLABORATOR` to the exclusion list. The corresponding fix for `maven-gh-actions-shared` (adding `COLLABORATOR`) was already pushed to `v5` as belt-and-suspenders: apache/maven-gh-actions-shared@70687eb Fixes: #13334 (PR by committer incorrectly blocked by license check) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
