gnodet-bot commented on code in PR #1154: URL: https://github.com/apache/maven-compiler-plugin/pull/1154#discussion_r4181596500
########## src/it/abi-incremental-cascade/verify.groovy: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// All class files should exist +assert new File( basedir, 'target/classes/api/Model.class' ).exists() +assert new File( basedir, 'target/classes/impl/Service.class' ).exists() + +// Graph state is stored in maven-status dir (not inside classes/ to avoid polluting JARs) +assert new File( basedir, 'target/maven-status/maven-compiler-plugin/classes/.incremental-state' ).exists() + +// Build should succeed (compilation didn't fail after cascade) +def logFile = new File( basedir, 'build.log' ) +assert logFile.exists() +def content = logFile.text + +// Should contain graph-related messages showing cascade behavior +// The step 3 compile should recompile more than just Model +assert !content.contains( 'COMPILATION ERROR' ) Review Comment: 💡 **Still not addressed (previous review):** This IT only verifies that compilation didn't fail (`!content.contains('COMPILATION ERROR')`), which passes trivially even if the graph strategy never activated (e.g. if the strategy silently fell back to timestamp). The basic IT now correctly checks for graph-strategy-specific log messages (`graph: full build`, `graph: incremental`). This cascade IT should do the same — plus verify that cascade actually happened by checking for the `graph cascade: recompiling` log message, which confirms that changing `Model`'s API triggered recompilation of `Service`. ```suggestion assert !content.contains( 'COMPILATION ERROR' ) // Step 1 should be a full build via the graph strategy assert content.contains( 'graph: full build' ) // Step 3 should show cascade behavior: Model API changed → Service recompiled assert content.contains( 'graph cascade: recompiling' ) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
