gnodet-bot commented on code in PR #13361: URL: https://github.com/apache/maven/pull/13361#discussion_r4193263375
########## its/core-it-suite/src/test/resources/mng-3004/subproject1/pom.xml: ########## @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.maven.its.mng3004</groupId> + <artifactId>parent</artifactId> + <version>1.0</version> + </parent> + + <artifactId>subproject1</artifactId> + <packaging>jar</packaging> + + <name>Maven Integration Test :: MNG-95 : Project 1</name> Review Comment: 💡 Same here: ```suggestion <name>Maven Integration Test :: MNG-3004 : Project 1</name> ``` ########## its/core-it-suite/src/test/resources/mng-3004/pom.xml: ########## @@ -0,0 +1,31 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.maven.its.mng3004</groupId> + <artifactId>parent</artifactId> + <version>1.0</version> + <packaging>pom</packaging> + + <name>Maven Integration Test :: MNG-95</name> Review Comment: 💡 **Nit:** The `<name>` still references MNG-95 (carried over from the mng-0095 copy). Since the whole point of this PR is to give MNG-3004 its own identity, this should match: ```suggestion <name>Maven Integration Test :: MNG-3004</name> ``` ########## its/core-it-suite/src/test/resources/mng-3004/subproject3/pom.xml: ########## @@ -0,0 +1,24 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.maven.its.mng3004</groupId> + <artifactId>parent</artifactId> + <version>1.0</version> + </parent> + + <artifactId>subproject3</artifactId> + <packaging>jar</packaging> + + <name>Maven Integration Test :: MNG-95 : Project 3</name> Review Comment: 💡 And here: ```suggestion <name>Maven Integration Test :: MNG-3004 : Project 3</name> ``` ########## its/core-it-suite/src/test/resources/mng-3004/subproject2/pom.xml: ########## @@ -0,0 +1,17 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.maven.its.mng3004</groupId> + <artifactId>parent</artifactId> + <version>1.0</version> + </parent> + + <artifactId>subproject2</artifactId> + <packaging>jar</packaging> + + <name>Maven Integration Test :: MNG-95 : Project 2</name> Review Comment: 💡 And here: ```suggestion <name>Maven Integration Test :: MNG-3004 : Project 2</name> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
